Issue 629283002: Simplify conversion of empty lists to null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 629283002: Simplify conversion of empty lists to null. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify conversion of empty lists to null. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40945

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -9 lines)			Patch
M	pkg/analysis_server/lib/src/collections.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_outline.dart	View	6 chunks	+6 lines, -5 lines	1 comment	Download
M	pkg/analysis_server/lib/src/computer/computer_overrides.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

https://codereview.chromium.org/629283002/diff/1/pkg/analysis_server/lib/src/computer/computer_outline.dart File pkg/analysis_server/lib/src/computer/computer_outline.dart (right): https://codereview.chromium.org/629283002/diff/1/pkg/analysis_server/lib/src/computer/computer_outline.dart#newcode182 pkg/analysis_server/lib/src/computer/computer_outline.dart:182: children: nullIfEmpty(classContents)); Actually, we could probably change the Outline ...

6 years, 2 months ago (2014-10-06 17:53:35 UTC) #2

scheglov

6 years, 2 months ago (2014-10-06 21:37:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40945 (presubmit successful).

Expand Messages | Collapse Messages