Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: pkg/analysis_server/lib/src/computer/computer_overrides.dart

Issue 629283002: Simplify conversion of empty lists to null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library computer.overrides; 5 library computer.overrides;
6 6
7 import 'package:analysis_server/src/collections.dart';
7 import 'package:analysis_server/src/protocol.dart'; 8 import 'package:analysis_server/src/protocol.dart';
8 import 'package:analyzer/src/generated/ast.dart'; 9 import 'package:analyzer/src/generated/ast.dart';
9 import 'package:analyzer/src/generated/element.dart' as engine; 10 import 'package:analyzer/src/generated/element.dart' as engine;
10 11
11 12
12 /** 13 /**
13 * A computer for class member overrides in a Dart [CompilationUnit]. 14 * A computer for class member overrides in a Dart [CompilationUnit].
14 */ 15 */
15 class DartUnitOverridesComputer { 16 class DartUnitOverridesComputer {
16 final CompilationUnit _unit; 17 final CompilationUnit _unit;
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 OverriddenMember superMember = superEngineElement != null ? 69 OverriddenMember superMember = superEngineElement != null ?
69 new OverriddenMember.fromEngine(superEngineElement) : 70 new OverriddenMember.fromEngine(superEngineElement) :
70 null; 71 null;
71 List<OverriddenMember> interfaceMembers = interfaceEngineElements.map( 72 List<OverriddenMember> interfaceMembers = interfaceEngineElements.map(
72 (engine.Element member) => new OverriddenMember.fromEngine(member)).to List(); 73 (engine.Element member) => new OverriddenMember.fromEngine(member)).to List();
73 _overrides.add( 74 _overrides.add(
74 new Override( 75 new Override(
75 offset, 76 offset,
76 length, 77 length,
77 superclassMember: superMember, 78 superclassMember: superMember,
78 interfaceMembers: interfaceMembers.isEmpty ? null : interfaceMembe rs)); 79 interfaceMembers: nullIfEmpty(interfaceMembers)));
79 } 80 }
80 } 81 }
81 82
82 static engine.Element _lookupMember(engine.ClassElement classElement, 83 static engine.Element _lookupMember(engine.ClassElement classElement,
83 String name) { 84 String name) {
84 if (classElement == null) { 85 if (classElement == null) {
85 return null; 86 return null;
86 } 87 }
87 engine.LibraryElement library = classElement.library; 88 engine.LibraryElement library = classElement.library;
88 // method 89 // method
89 engine.Element member = classElement.lookUpMethod(name, library); 90 engine.Element member = classElement.lookUpMethod(name, library);
90 if (member != null) { 91 if (member != null) {
91 return member; 92 return member;
92 } 93 }
93 // getter 94 // getter
94 member = classElement.lookUpGetter(name, library); 95 member = classElement.lookUpGetter(name, library);
95 if (member != null) { 96 if (member != null) {
96 return member; 97 return member;
97 } 98 }
98 // setter 99 // setter
99 member = classElement.lookUpSetter(name + '=', library); 100 member = classElement.lookUpSetter(name + '=', library);
100 if (member != null) { 101 if (member != null) {
101 return member; 102 return member;
102 } 103 }
103 // not found 104 // not found
104 return null; 105 return null;
105 } 106 }
106 } 107 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698