Issue 628293004: Remove references to Engine classes from protocol.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 628293004: Remove references to Engine classes from protocol.dart (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove references to Engine classes from protocol.dart R=brianwilkerson@google.com, paulberry@google.com, danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40948

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+661 lines, -814 lines)			Patch
M	pkg/analysis_server/lib/src/computer/computer_navigation.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_occurrences.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_overrides.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/computer/element.dart	View	2 chunks	+13 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_analysis.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	12 chunks	+0 lines, -99 lines	0 comments	Download
M	pkg/analysis_server/lib/src/operation/operation_analysis.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/protocol.dart	View	6 chunks	+0 lines, -298 lines	0 comments	Download
A	pkg/analysis_server/lib/src/protocol_server.dart	View	1 chunk	+357 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/search/element_references.dart	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/lib/src/search/search_domain.dart	View	7 chunks	+24 lines, -16 lines	0 comments	Download
D	pkg/analysis_server/lib/src/search/search_result.dart	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/imported_computer.dart	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart	View	4 chunks	+7 lines, -8 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_local.dart	View	9 chunks	+75 lines, -73 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_method.dart	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/inline_local.dart	View	5 chunks	+10 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/inline_method.dart	View	12 chunks	+20 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/move_file.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart	View	5 chunks	+6 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_import.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_local.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/computer/element_test.dart	View	10 chunks	+25 lines, -25 lines	0 comments	Download
M	pkg/analysis_server/test/computer/error_test.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/search/search_result_test.dart	View	3 chunks	+10 lines, -9 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/change_test.dart	View	4 chunks	+21 lines, -16 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/status_test.dart	View	5 chunks	+9 lines, -8 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/codegen_dart_protocol.dart	View	5 chunks	+0 lines, -107 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 2 months ago (2014-10-07 00:25:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40948 (presubmit successful).

Expand Messages | Collapse Messages