pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart - Issue 628293004: Remove references to Engine classes from protocol.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

Issue 628293004: Remove references to Engine classes from protocol.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/extract_local.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

index c8fe46018737ed72859bd7515c0e692d5231639e..6b63f7692fe243490679bfa642e9df8f83ae55a7 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

@@ -6,7 +6,7 @@ library services.src.refactoring.convert_method_to_getter;

import 'dart:async';

-import 'package:analysis_server/src/protocol.dart' hide Element;

+import 'package:analysis_server/src/protocol_server.dart' hide Element;

import 'package:analysis_server/src/services/correction/source_range.dart';

import 'package:analysis_server/src/services/correction/status.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

@@ -105,12 +105,12 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl implements

// insert "get "

{

SourceEdit edit = new SourceEdit(element.nameOffset, 0, 'get ');

- change.addElementEdit(element, edit);

+ doSourceChange_addElementEdit(change, element, edit);

}

// remove parameters

{

- SourceEdit edit = new SourceEdit.range(rangeNode(parameters), '');

- change.addElementEdit(element, edit);

+ SourceEdit edit = newSourceEdit_range(rangeNode(parameters), '');

+ doSourceChange_addElementEdit(change, element, edit);

}

@@ -131,8 +131,8 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl implements

// we need invocation

if (invocation != null) {

SourceRange range = rangeEndEnd(refRange, invocation);

- SourceEdit edit = new SourceEdit.range(range, '');

- change.addElementEdit(refElement, edit);

+ SourceEdit edit = newSourceEdit_range(range, '');

+ doSourceChange_addElementEdit(change, element, edit);

}

});