Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 62203018: Remove dead code from IfThenElse and StrictCompare in the compiler. (Closed)

Created:
7 years, 1 month ago by Florian Schneider
Modified:
7 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove dead code from IfThenElse and StrictCompare in the compiler. The code for these cases is either completely unused or can only be hit with canonicalization and constant propagation turned off. Since this is not tested, and does not bring any performance benefit for the default configuration it is best to just remove it. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30393

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -82 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 chunks +5 lines, -12 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 chunks +5 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 chunks +5 lines, -12 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 1 month ago (2013-11-14 16:13:08 UTC) #1
srdjan
lgtm
7 years, 1 month ago (2013-11-19 00:49:24 UTC) #2
Florian Schneider
7 years, 1 month ago (2013-11-19 10:38:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698