Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 62203018: Remove dead code from IfThenElse and StrictCompare in the compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1471 locs); 1471 locs);
1472 AddStaticCallTarget(function); 1472 AddStaticCallTarget(function);
1473 __ Drop(argument_count); 1473 __ Drop(argument_count);
1474 } 1474 }
1475 1475
1476 1476
1477 void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg, 1477 void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
1478 const Object& obj, 1478 const Object& obj,
1479 bool needs_number_check, 1479 bool needs_number_check,
1480 intptr_t token_pos) { 1480 intptr_t token_pos) {
1481 if (needs_number_check) { 1481 ASSERT(!needs_number_check ||
1482 if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) { 1482 (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()));
1483 needs_number_check = false;
1484 }
1485 }
1486 1483
1487 if (obj.IsSmi() && (Smi::Cast(obj).Value() == 0)) { 1484 if (obj.IsSmi() && (Smi::Cast(obj).Value() == 0)) {
1488 ASSERT(!needs_number_check); 1485 ASSERT(!needs_number_check);
1489 __ testq(reg, reg); 1486 __ testq(reg, reg);
1490 return; 1487 return;
1491 } 1488 }
1492 1489
1493 if (needs_number_check) { 1490 if (needs_number_check) {
1494 __ pushq(reg); 1491 __ pushq(reg);
1495 __ PushObject(obj, PP); 1492 __ PushObject(obj, PP);
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
1898 __ movups(reg, Address(RSP, 0)); 1895 __ movups(reg, Address(RSP, 0));
1899 __ AddImmediate(RSP, Immediate(kFpuRegisterSize), PP); 1896 __ AddImmediate(RSP, Immediate(kFpuRegisterSize), PP);
1900 } 1897 }
1901 1898
1902 1899
1903 #undef __ 1900 #undef __
1904 1901
1905 } // namespace dart 1902 } // namespace dart
1906 1903
1907 #endif // defined TARGET_ARCH_X64 1904 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698