Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 621383002: Change integration test send...() methods to use structured objects. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change integration test send...() methods to use structured objects. This is less error prone than using raw JSON, and requires less effort when writing integration tests. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=40904

Patch Set 1 #

Patch Set 2 : Reintroduce type checking of server responses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -418 lines) Patch
M pkg/analysis_server/test/integration/analysis/highlights_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/navigation_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/occurrences_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/outline_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/overrides_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_list_test.dart View 3 chunks +6 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 2 chunks +8 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 27 chunks +76 lines, -243 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/timing/completion/completion_simple.dart View 3 chunks +4 lines, -12 lines 0 comments Download
A pkg/analysis_server/tool/spec/codegen_dart.dart View 1 chunk +51 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 6 chunks +29 lines, -59 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 9 chunks +27 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
Still to come: - Use structured objects for replies - Use structured objects for notifications
6 years, 2 months ago (2014-10-03 18:14:02 UTC) #2
Paul Berry
Whoops, in the first draft I accidentally deleted the code that type checks the responses ...
6 years, 2 months ago (2014-10-03 18:23:59 UTC) #3
Brian Wilkerson
LGTM! This looks much less fragile.
6 years, 2 months ago (2014-10-03 18:25:26 UTC) #4
Paul Berry
6 years, 2 months ago (2014-10-03 18:52:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698