Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 621383002: Change integration test send...() methods to use structured objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reintroduce type checking of server responses Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index d64f53dcf727867c0a5467c3b79e42c718174b07..1971bd78a01c02eb4dcc3e4ef6ad599ba53d5a85 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -10,6 +10,7 @@ import 'dart:convert';
import 'dart:io';
import 'package:analysis_server/src/constants.dart';
+import 'package:analysis_server/src/protocol.dart';
import 'package:path/path.dart';
import 'package:unittest/unittest.dart';
@@ -96,7 +97,7 @@ abstract class AbstractAnalysisServerIntegrationTest extends
Future standardAnalysisSetup({bool subscribeStatus: true}) {
List<Future> futures = <Future>[];
if (subscribeStatus) {
- futures.add(sendServerSetSubscriptions(['STATUS']));
+ futures.add(sendServerSetSubscriptions([ServerService.STATUS]));
}
futures.add(sendAnalysisSetAnalysisRoots([sourceDirectory.path], []));
return Future.wait(futures);
@@ -143,11 +144,9 @@ abstract class AbstractAnalysisServerIntegrationTest extends
}
@override
- Future sendServerSetSubscriptions(List<String> subscriptions, {bool
- checkTypes: true}) {
- _subscribedToServerStatus = subscriptions.contains('STATUS');
- return super.sendServerSetSubscriptions(subscriptions, checkTypes:
- checkTypes);
+ Future sendServerSetSubscriptions(List<ServerService> subscriptions) {
+ _subscribedToServerStatus = subscriptions.contains(ServerService.STATUS);
+ return super.sendServerSetSubscriptions(subscriptions);
}
/**

Powered by Google App Engine
This is Rietveld 408576698