Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 618353002: Revert r40848 (Closed)

Created:
6 years, 2 months ago by Cutch
Modified:
6 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -112 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 4 chunks +22 lines, -21 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 3 chunks +9 lines, -22 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 4 chunks +25 lines, -18 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 5 chunks +30 lines, -23 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +9 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
TBR
6 years, 2 months ago (2014-10-01 18:26:52 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as 40850 (presubmit successful).
6 years, 2 months ago (2014-10-01 18:27:17 UTC) #3
Cutch
6 years, 2 months ago (2014-10-01 18:28:18 UTC) #4
Message was sent while issue was closed.
On 2014/10/01 18:26:52, Cutch wrote:
> TBR

Regressed benchmark by 5% and caused a failure on X64.

Powered by Google App Engine
This is Rietveld 408576698