Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 618353002: Revert r40848 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm64.cc
diff --git a/runtime/vm/intermediate_language_arm64.cc b/runtime/vm/intermediate_language_arm64.cc
index 36510f4bdcf0950a53013fec4aee60689d7add3b..651371dfa933af4185a4d75942a4857217684b28 100644
--- a/runtime/vm/intermediate_language_arm64.cc
+++ b/runtime/vm/intermediate_language_arm64.cc
@@ -993,11 +993,9 @@ Representation LoadIndexedInstr::representation() const {
case kTypedDataUint16ArrayCid:
case kOneByteStringCid:
case kTwoByteStringCid:
- return kTagged;
case kTypedDataInt32ArrayCid:
- return kUnboxedInt32;
case kTypedDataUint32ArrayCid:
- return kUnboxedUint32;
+ return kTagged;
case kTypedDataFloat32ArrayCid:
case kTypedDataFloat64ArrayCid:
return kUnboxedDouble;
@@ -1095,25 +1093,6 @@ void LoadIndexedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
return;
}
- if ((representation() == kUnboxedInt32) ||
- (representation() == kUnboxedUint32)) {
- const Register result = locs()->out(0).reg();
- switch (class_id()) {
- case kTypedDataInt32ArrayCid:
- ASSERT(representation() == kUnboxedInt32);
- __ ldr(result, element_address, kWord);
- break;
- case kTypedDataUint32ArrayCid:
- ASSERT(representation() == kUnboxedUint32);
- __ ldr(result, element_address, kUnsignedWord);
- break;
- default:
- UNREACHABLE();
- }
- return;
- }
-
- ASSERT(representation() == kTagged);
const Register result = locs()->out(0).reg();
switch (class_id()) {
case kTypedDataInt8ArrayCid:
@@ -1139,6 +1118,14 @@ void LoadIndexedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ ldr(result, element_address, kUnsignedHalfword);
__ SmiTag(result);
break;
+ case kTypedDataInt32ArrayCid:
+ __ ldr(result, element_address, kWord);
+ __ SmiTag(result);
+ break;
+ case kTypedDataUint32ArrayCid:
+ __ ldr(result, element_address, kUnsignedWord);
+ __ SmiTag(result);
+ break;
default:
ASSERT((class_id() == kArrayCid) || (class_id() == kImmutableArrayCid));
__ ldr(result, element_address);
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698