Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 61733013: Add SplayTreeSet. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix retainAll - uses correct equality. Will add test. #

Patch Set 3 : Add test for retainAll. #

Patch Set 4 : More efficient retainsAll. #

Patch Set 5 : More efficient retainAll #

Patch Set 6 : Updated doc on intersection/difference: elements always comes from receiver, and other.contains is … #

Patch Set 7 : Added more tests #

Total comments: 5

Patch Set 8 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -53 lines) Patch
M sdk/lib/collection/hash_set.dart View 1 2 3 4 5 1 chunk +2 lines, -8 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 2 3 4 5 6 7 7 chunks +201 lines, -19 lines 0 comments Download
M sdk/lib/core/set.dart View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/set_test.dart View 1 2 3 4 5 6 4 chunks +88 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-11-13 14:11:31 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/61733013/diff/130001/sdk/lib/collection/splay_tree.dart File sdk/lib/collection/splay_tree.dart (right): https://codereview.chromium.org/61733013/diff/130001/sdk/lib/collection/splay_tree.dart#newcode140 sdk/lib/collection/splay_tree.dart:140: // After this, the smallest element in the ...
7 years, 1 month ago (2013-11-18 18:36:19 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/61733013/diff/130001/sdk/lib/core/set.dart File sdk/lib/core/set.dart (right): https://codereview.chromium.org/61733013/diff/130001/sdk/lib/core/set.dart#newcode120 sdk/lib/core/set.dart:120: * are also elements of `other` according to `other.contains`. ...
7 years, 1 month ago (2013-11-20 09:34:50 UTC) #3
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-11-20 09:35:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #8 manually as r30444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698