Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 61683007: Reapply "Retain types of toplevel and instance variables for reflection." (Closed)

Created:
7 years, 1 month ago by zarah
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Reapply "Retain types of toplevel and instance variables for reflection." This reverts commit r30222. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=30224

Patch Set 1 #

Patch Set 2 : Fix: use '-' instead of ':' as a separator in the field descriptor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -42 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 1 chunk +6 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/declarations.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 7 chunks +28 lines, -23 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +2 lines, -5 lines 0 comments Download
A tests/lib/mirrors/field_type_test.dart View 1 chunk +76 lines, -0 lines 0 comments Download
M tests/lib/mirrors/generic_type_mirror_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zarah
7 years, 1 month ago (2013-11-13 12:19:15 UTC) #1
karlklose
LGTM.
7 years, 1 month ago (2013-11-13 12:21:07 UTC) #2
zarah
7 years, 1 month ago (2013-11-13 12:43:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698