sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart - Issue 61683007: Reapply "Retain types of toplevel and instance variables for reflection."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 61683007: Reapply "Retain types of toplevel and instance variables for reflection." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix: use '-' instead of ':' as a separator in the field descriptor. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/declarations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

index dd2d29390f529dcf3bdaf78c304fe10420138d57..cd98aad34b15674f9cc6783cc3070328d478862d 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

@@ -137,16 +137,14 @@ class CodeEmitterTask extends CompilerTask {

String reflectableField = namer.reflectableField;

// function generateAccessor(field, prototype, cls) {

- jsAst.Fun fun = js.fun(['field', 'accessors', 'cls'], [

+ jsAst.Fun fun = js.fun(['fieldDescriptor', 'accessors', 'cls'], [

+ js('var fieldInformation = fieldDescriptor.split("-")'),

+ js('var field = fieldInformation[0]'),

js('var len = field.length'),

js('var code = field.charCodeAt(len - 1)'),

- js('var reflectable = false'),

- js.if_('code == $REFLECTION_MARKER', [

- js('len--'),

- js('code = field.charCodeAt(len - 1)'),

- js('field = field.substring(0, len)'),

- js('reflectable = true')

- ]),

+ js('var reflectable'),

+ js.if_('fieldInformation.length > 1', js('reflectable = true'),

+ js('reflectable = false')),

js('code = ((code >= $RANGE1_FIRST) && (code <= $RANGE1_LAST))'

' ? code - $RANGE1_ADJUST'

' : ((code >= $RANGE2_FIRST) && (code <= $RANGE2_LAST))'