Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 613063002: Make Node.nodes.insertAll take an end-positioned index. (Closed)

Created:
6 years, 2 months ago by sra1
Modified:
6 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org, ricow1, vsm
Visibility:
Public.

Description

Make Node.nodes.insertAll work for an end-positioned index. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=40819

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +9 lines, -5 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
6 years, 2 months ago (2014-09-30 01:07:21 UTC) #2
blois
lgtm
6 years, 2 months ago (2014-09-30 15:48:03 UTC) #3
sra1
6 years, 2 months ago (2014-09-30 17:54:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698