sdk/lib/html/dart2js/html_dart2js.dart - Issue 613063002: Make Node.nodes.insertAll take an end-positioned index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 613063002: Make Node.nodes.insertAll take an end-positioned index. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 864fbb476d77abc7e5c978657b87e20c94301475..9a28764cdf159a8f8143b7497484c17dbf73a702 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -21572,8 +21572,12 @@ class _ChildNodeListLazy extends ListBase<Node> implements NodeListWrapper {

}

void insertAll(int index, Iterable<Node> iterable) {

- var item = this[index];

- _this.insertAllBefore(iterable, item);

+ if (index == length) {

+ addAll(iterable);

+ } else {

+ var item = this[index];

+ _this.insertAllBefore(iterable, item);

+ }

}

void setAll(int index, Iterable<Node> iterable) {

« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »