Issue 612133004: Write barrier audit: const raw_ptr()

Issue 612133004: Write barrier audit: const raw_ptr() (Closed)

Created:
6 years, 2 months ago by koda

Modified:
6 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Write barrier audit: const raw_ptr() raw_ptr() now returns a const*, and all writes within objects must be routed through a well-defined set of methods on Object. Note: This also includes writes to non-pointer fields, to enable low-level verification of all writes. Additionally, it allows enforcing a NoGCScope around such writes to protect against moving objects. Add a bunch of these (now required) NoGCScopes. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41058

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -111 lines)			Patch
M	runtime/vm/object.h	View	1 2 3 4	31 chunks	+113 lines, -43 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	38 chunks	+51 lines, -48 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4	13 chunks	+17 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2 3 4	9 chunks	+37 lines, -18 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 2 3 4	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/612133004/diff/60001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/612133004/diff/60001/runtime/vm/object.h#newcode592 runtime/vm/object.h:592: void StorePointer(const type* addr, type value) const ...

6 years, 2 months ago (2014-10-10 23:52:11 UTC) #2

koda

https://codereview.chromium.org/612133004/diff/60001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/612133004/diff/60001/runtime/vm/object.h#newcode592 runtime/vm/object.h:592: void StorePointer(const type* addr, type value) const { On ...

6 years, 2 months ago (2014-10-11 00:26:33 UTC) #3

koda

6 years, 2 months ago (2014-10-11 00:27:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 (id:110001) manually as r41058 (presubmit successful).

Expand Messages | Collapse Messages