Write barrier audit: const raw_ptr()

runtime/vm/raw_object_snapshot.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/snapshot.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 #include "vm/visitor.h"
@@ skipping 931 matching lines @@
   // TODO(5411462): Need to assert No GC can happen here, even though
   // allocations may happen.
   *reader->StringHandle() ^= reader->ReadObjectImpl();
   script.set_url(*reader->StringHandle());
   *reader->StringHandle() ^= String::null();
   script.set_source(*reader->StringHandle());
   TokenStream& stream = TokenStream::Handle();
   stream ^= reader->ReadObjectImpl();
   script.set_tokens(stream);
 
-  script.raw_ptr()->line_offset_ = reader->Read<int32_t>();
-  script.raw_ptr()->col_offset_ = reader->Read<int32_t>();
-  script.raw_ptr()->kind_ = reader->Read<int8_t>();
+  script.StoreNonPointer(&script.raw_ptr()->line_offset_,
+                         reader->Read<int32_t>());
+  script.StoreNonPointer(&script.raw_ptr()->col_offset_,
+                         reader->Read<int32_t>());
+  script.StoreNonPointer(&script.raw_ptr()->kind_,
+                         reader->Read<int8_t>());
 
   return script.raw();
 }
 
 
 void RawScript::WriteTo(SnapshotWriter* writer,
                         intptr_t object_id,
                         Snapshot::Kind kind) {
   ASSERT(writer != NULL);
   ASSERT(tokens_ != TokenStream::null());
@@ skipping 34 matching lines @@
     *reader->StringHandle() ^= reader->ReadObjectImpl();
     library = Library::LookupLibrary(*reader->StringHandle());
   } else {
     // Allocate library object.
     library = NEW_OBJECT(Library);
 
     // Set the object tags.
     library.set_tags(tags);
 
     // Set all non object fields.
-    library.raw_ptr()->index_ = reader->Read<int32_t>();
-    library.raw_ptr()->num_imports_ = reader->Read<int32_t>();
-    library.raw_ptr()->num_anonymous_ = reader->Read<int32_t>();
-    library.raw_ptr()->corelib_imported_ = reader->Read<bool>();
-    library.raw_ptr()->is_dart_scheme_ = reader->Read<bool>();
-    library.raw_ptr()->debuggable_ = reader->Read<bool>();
-    library.raw_ptr()->load_state_ = reader->Read<int8_t>();
+    library.StoreNonPointer(&library.raw_ptr()->index_,
+                            reader->Read<int32_t>());
+    library.StoreNonPointer(&library.raw_ptr()->num_imports_,
+                            reader->Read<int32_t>());
+    library.StoreNonPointer(&library.raw_ptr()->num_anonymous_,
+                            reader->Read<int32_t>());
+    library.StoreNonPointer(&library.raw_ptr()->corelib_imported_,
+                            reader->Read<bool>());
+    library.StoreNonPointer(&library.raw_ptr()->is_dart_scheme_,
+                            reader->Read<bool>());
+    library.StoreNonPointer(&library.raw_ptr()->debuggable_,
+                            reader->Read<bool>());
+    library.StoreNonPointer(&library.raw_ptr()->load_state_,
+                            reader->Read<int8_t>());
     // The native resolver is not serialized.
     Dart_NativeEntryResolver resolver =
         reader->Read<Dart_NativeEntryResolver>();
     ASSERT(resolver == NULL);
     library.set_native_entry_resolver(resolver);
     // The symbol resolver is not serialized.
     Dart_NativeEntrySymbol symbol_resolver =
         reader->Read<Dart_NativeEntrySymbol>();
     ASSERT(symbol_resolver == NULL);
     library.set_native_entry_symbol_resolver(symbol_resolver);
     // The cache of loaded scripts is not serialized.
-    library.raw_ptr()->loaded_scripts_ = Array::null();
+    library.StorePointer(&library.raw_ptr()->loaded_scripts_, Array::null());
 
     // Set all the object fields.
     // TODO(5411462): Need to assert No GC can happen here, even though
     // allocations may happen.
     intptr_t num_flds = (library.raw()->to() - library.raw()->from());
     for (intptr_t i = 0; i <= num_flds; i++) {
       *(library.raw()->from() + i) = reader->ReadObjectRef();
     }
     if (kind != Snapshot::kFull) {
       library.Register();
@@ skipping 58 matching lines @@
 
   // Allocate library prefix object.
   LibraryPrefix& prefix = LibraryPrefix::ZoneHandle(
       reader->isolate(), NEW_OBJECT(LibraryPrefix));
   reader->AddBackRef(object_id, &prefix, kIsDeserialized);
 
   // Set the object tags.
   prefix.set_tags(tags);
 
   // Set all non object fields.
-  prefix.raw_ptr()->num_imports_ = reader->Read<int32_t>();
-  prefix.raw_ptr()->is_deferred_load_ = reader->Read<bool>();
-  prefix.raw_ptr()->is_loaded_ = reader->Read<bool>();
+  prefix.StoreNonPointer(&prefix.raw_ptr()->num_imports_,
+                         reader->Read<int32_t>());
+  prefix.StoreNonPointer(&prefix.raw_ptr()->is_deferred_load_,
+                         reader->Read<bool>());
+  prefix.StoreNonPointer(&prefix.raw_ptr()->is_loaded_, reader->Read<bool>());
 
   // Set all the object fields.
   // TODO(5411462): Need to assert No GC can happen here, even though
   // allocations may happen.
   intptr_t num_flds = (prefix.raw()->to() - prefix.raw()->from());
   for (intptr_t i = 0; i <= num_flds; i++) {
     *(prefix.raw()->from() + i) = reader->ReadObjectRef();
   }
 
   return prefix.raw();
@@ skipping 728 matching lines @@
         isolate->current_zone()->Alloc<CharacterType>(len);
     for (intptr_t i = 0; i < len; i++) {
       ptr[i] = reader->Read<CharacterType>();
     }
     *str_obj ^= (*new_symbol)(ptr, len);
   } else {
     // Set up the string object.
     *str_obj = StringType::New(len, HEAP_SPACE(kind));
     str_obj->set_tags(tags);
     str_obj->SetHash(0);  // Will get computed when needed.
+    NoGCScope no_gc;
     for (intptr_t i = 0; i < len; i++) {
       *StringType::CharAddr(*str_obj, i) = reader->Read<CharacterType>();
     }
   }
 }
 
 
 RawOneByteString* OneByteString::ReadFrom(SnapshotReader* reader,
                                           intptr_t object_id,
                                           intptr_t tags,
@@ skipping 32 matching lines @@
   ASSERT(reader != NULL);
   intptr_t len = reader->ReadSmiValue();
   intptr_t hash = reader->ReadSmiValue();
   String& str_obj = String::Handle(reader->isolate(), String::null());
 
   if (kind == Snapshot::kFull) {
     RawTwoByteString* obj = reader->NewTwoByteString(len);
     str_obj = obj;
     str_obj.set_tags(tags);
     obj->ptr()->hash_ = Smi::New(hash);
+    NoGCScope no_gc;
     uint16_t* raw_ptr = (len > 0)? CharAddr(str_obj, 0) : NULL;
     for (intptr_t i = 0; i < len; i++) {
       ASSERT(CharAddr(str_obj, i) == raw_ptr);  // Will trigger assertions.
       *raw_ptr = reader->Read<uint16_t>();
       raw_ptr += 1;
     }
     ASSERT(String::Hash(str_obj, 0, str_obj.Length()) == hash);
   } else {
     String::ReadFromImpl<TwoByteString, uint16_t>(
         reader, &str_obj, len, tags, Symbols::FromUTF16, kind);
@@ skipping 448 matching lines @@
   // Set the object tags.
   result.set_tags(tags);
 
   // Setup the array elements.
   intptr_t element_size = ElementSizeInBytes(cid);
   intptr_t length_in_bytes = len * element_size;
   switch (cid) {
     case kTypedDataInt8ArrayCid:
     case kTypedDataUint8ArrayCid:
     case kTypedDataUint8ClampedArrayCid: {
+      NoGCScope no_gc;
       uint8_t* data = reinterpret_cast<uint8_t*>(result.DataAddr(0));
       reader->ReadBytes(data, length_in_bytes);
       break;
     }
     case kTypedDataInt16ArrayCid:
       TYPED_DATA_READ(Int16, int16_t);
       break;
     case kTypedDataUint16ArrayCid:
       TYPED_DATA_READ(Uint16, uint16_t);
       break;
@@ skipping 328 matching lines @@
 
   // Allocate JSRegExp object.
   JSRegExp& regex = JSRegExp::ZoneHandle(
       reader->isolate(), JSRegExp::New(len, HEAP_SPACE(kind)));
   reader->AddBackRef(object_id, &regex, kIsDeserialized);
 
   // Set the object tags.
   regex.set_tags(tags);
 
   // Read and Set all the other fields.
-  regex.raw_ptr()->num_bracket_expressions_ = reader->ReadAsSmi();
+  regex.StoreSmi(&regex.raw_ptr()->num_bracket_expressions_,
+                 reader->ReadAsSmi());
   *reader->StringHandle() ^= reader->ReadObjectImpl();
   regex.set_pattern(*reader->StringHandle());
-  regex.raw_ptr()->type_flags_ = reader->Read<int8_t>();
+  regex.StoreNonPointer(&regex.raw_ptr()->type_flags_,
+                        reader->Read<int8_t>());
 
   // TODO(5411462): Need to implement a way of recompiling the regex.
 
   return regex.raw();
 }
 
 
 void RawJSRegExp::WriteTo(SnapshotWriter* writer,
                           intptr_t object_id,
                           Snapshot::Kind kind) {
@@ skipping 27 matching lines @@
 
   // Allocate the weak property object.
   WeakProperty& weak_property = WeakProperty::ZoneHandle(
       reader->isolate(), WeakProperty::New(HEAP_SPACE(kind)));
   reader->AddBackRef(object_id, &weak_property, kIsDeserialized);
 
   // Set the object tags.
   weak_property.set_tags(tags);
 
   // Set all the object fields.
-  weak_property.raw_ptr()->key_ = reader->ReadObjectRef();
-  weak_property.raw_ptr()->value_ = reader->ReadObjectRef();
+  weak_property.StorePointer(&weak_property.raw_ptr()->key_,
+                             reader->ReadObjectRef());
+  weak_property.StorePointer(&weak_property.raw_ptr()->value_,
+                             reader->ReadObjectRef());
 
   return weak_property.raw();
 }
 
 
 void RawWeakProperty::WriteTo(SnapshotWriter* writer,
                           intptr_t object_id,
                           Snapshot::Kind kind) {
   ASSERT(writer != NULL);
 
@@ skipping 49 matching lines @@
     // We do not allow objects with native fields in an isolate message.
     writer->SetWriteException(Exceptions::kArgument,
                               "Illegal argument in isolate message"
                               " : (object is a UserTag)");
   } else {
     UNREACHABLE();
   }
 }
 
 }  // namespace dart