Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 608533003: Properly report assets from static packages as not found. (Closed)

Created:
6 years, 2 months ago by nweiz
Modified:
6 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly report assets from static packages as not found. R=rnystrom@google.com BUG=21087 Committed: https://code.google.com/p/dart/source/detail?r=40695

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -29 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart View 3 chunks +13 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart View 1 2 chunks +62 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/pub_package_provider.dart View 1 chunk +50 lines, -24 lines 0 comments Download
M sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart View 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nweiz
6 years, 2 months ago (2014-09-25 20:42:33 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/608533003/diff/1/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart File sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart (right): https://codereview.chromium.org/608533003/diff/1/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart#newcode53 sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart:53: "lib/does/not/exist.dart: \${results.last}")); Indent this either 0 or +4 ...
6 years, 2 months ago (2014-09-25 21:20:12 UTC) #2
nweiz
Code review changes
6 years, 2 months ago (2014-09-25 21:28:44 UTC) #3
nweiz
https://codereview.chromium.org/608533003/diff/1/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart File sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart (right): https://codereview.chromium.org/608533003/diff/1/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart#newcode53 sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart:53: "lib/does/not/exist.dart: \${results.last}")); On 2014/09/25 21:20:12, Bob Nystrom wrote: > ...
6 years, 2 months ago (2014-09-25 21:29:22 UTC) #4
nweiz
Committed patchset #2 (id:20001) manually as 40695 (presubmit successful).
6 years, 2 months ago (2014-09-25 21:29:38 UTC) #5
Bob Nystrom
Does this need to get cherry-picked for 1.7? If so, make sure Rico knows. I ...
6 years, 2 months ago (2014-09-25 22:00:22 UTC) #6
jakemac
6 years, 2 months ago (2014-09-25 22:19:00 UTC) #7
Message was sent while issue was closed.
On 2014/09/25 22:00:22, Bob Nystrom wrote:
> Does this need to get cherry-picked for 1.7? If so, make sure Rico knows. I
> think there's a form to fill out to request a cherry-pick, but I can't recall
> the URL.

Its breaking the Polymer transformers to it would be good to get it cherry
picked if we can

Powered by Google App Engine
This is Rietveld 408576698