Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart

Issue 608533003: Properly report assets from static packages as not found. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub_generated/lib/src/barback/pub_package_provider.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart
diff --git a/sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart b/sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart
index 6a056855db4513b13be6d7af8bebc1ff9c12e11f..7661ff61a4392f200d55fc717513fb7a7d2af25a 100644
--- a/sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart
+++ b/sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart
@@ -24,6 +24,29 @@ class ModeTransformer extends Transformer {
}
}
""";
+const HAS_INPUT_TRANSFORMER = """
+import 'dart:async';
+
+import 'package:barback/barback.dart';
+
+class HasInputTransformer extends Transformer {
+ HasInputTransformer.asPlugin();
+
+ bool get allowedExtensions => '.txt';
+
+ Future apply(Transform transform) {
+ return Future.wait([
+ transform.hasInput(new AssetId("foo", "lib/foo.dart")),
+ transform.hasInput(new AssetId("foo", "lib/does/not/exist.dart"))
+ ]).then((results) {
+ transform.addOutput(new Asset.fromString(
+ transform.primaryInput.id,
+ "lib/foo.dart: \${results.first}, "
+ "lib/does/not/exist.dart: \${results.last}"));
+ });
+ }
+}
+""";
main() {
initConfig();
integration("caches a transformed dependency", () {
@@ -278,6 +301,39 @@ main() {
pub.stdout.expect("Hello!");
pub.shouldExit();
});
+ integration("hasInput works for static packages", () {
+ servePackages((builder) {
+ builder.serveRepoPackage('barback');
+ builder.serve("foo", "1.2.3", deps: {
+ 'barback': 'any'
+ }, pubspec: {
+ 'transformers': ['foo']
+ },
+ contents: [
+ d.dir(
+ "lib",
+ [
+ d.file("transformer.dart", replaceTransformer("Hello", "Goodbye")),
+ d.file("foo.dart", "void main() => print('Hello!');")])]);
+ });
+ d.dir(appPath, [d.pubspec({
+ "name": "myapp",
+ "dependencies": {
+ "foo": "1.2.3"
+ },
+ "transformers": ["myapp/src/transformer"]
+ }),
+ d.dir(
+ "lib",
+ [d.dir("src", [d.file("transformer.dart", HAS_INPUT_TRANSFORMER)])]),
+ d.dir("web", [d.file("foo.txt", "foo")])]).create();
+ pubGet(output: contains("Precompiled foo."));
+ pubServe();
+ requestShouldSucceed(
+ "foo.txt",
+ "lib/foo.dart: true, lib/does/not/exist.dart: false");
+ endPubServe();
+ });
}
String replaceTransformer(String input, String output) {
return """
« no previous file with comments | « sdk/lib/_internal/pub_generated/lib/src/barback/pub_package_provider.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698