Issue 608213002: Fix bad call of RangeError.value in String.fromCharCodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 608213002: Fix bad call of RangeError.value in String.fromCharCodes. (Closed)

Created:
6 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix bad call of RangeError.value in String.fromCharCodes. Committed: https://code.google.com/p/dart/source/detail?r=40760

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -9 lines)			Patch
M	runtime/lib/string_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/core_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/string_fromcharcodes_test.dart	View	2 chunks	+11 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 40760 (presubmit successful).

6 years, 2 months ago (2014-09-29 09:33:19 UTC) #3

Message was sent while issue was closed.

lgtm