runtime/lib/string_patch.dart - Issue 608213002: Fix bad call of RangeError.value in String.fromCharCodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string_patch.dart

Issue 608213002: Fix bad call of RangeError.value in String.fromCharCodes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/string_patch.dart

diff --git a/runtime/lib/string_patch.dart b/runtime/lib/string_patch.dart

index c3c2b40668264186bd217de6d807d1d250399948..da41fe91dde1681f1f6b27c20622db784fd25a5a 100644

--- a/runtime/lib/string_patch.dart

+++ b/runtime/lib/string_patch.dart

@@ -69,7 +69,7 @@ class _StringBase {

// Treat charCodes as Iterable.

if (start < 0) throw new RangeError.range(start, 0, charCodes.length);

if (end != null && end < start) {

- throw new RangeError.value(end, start, charCodes.length);

+ throw new RangeError.range(end, start, charCodes.length);

}

var it = charCodes.iterator;

for (int i = 0; i < start; i++) {

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/js_lib/core_patch.dart » ('j') | no next file with comments »