Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 60763004: Print drt exitcode when we pass test but crash before exiting (Closed)

Created:
7 years, 1 month ago by ricow1
Modified:
7 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Print drt exitcode when we pass test but crash before exiting R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=30401

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/testing/dart/test_runner.dart View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 1 month ago (2013-11-19 11:43:53 UTC) #1
kustermann
LGTM
7 years, 1 month ago (2013-11-19 11:56:59 UTC) #2
kustermann
Still LGTM
7 years, 1 month ago (2013-11-19 12:08:34 UTC) #3
ricow1
7 years, 1 month ago (2013-11-19 12:08:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r30401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698