Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 606893002: Avoids vmovsr on ARM. (Closed)

Created:
6 years, 2 months ago by zra
Modified:
6 years, 2 months ago
Reviewers:
regis, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -40 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 2 chunks +21 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 11 chunks +22 lines, -38 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zra
6 years, 2 months ago (2014-09-25 21:55:00 UTC) #2
regis
LGTM Is vmovsr much slower or unavailable on some platforms? https://codereview.chromium.org/606893002/diff/1/runtime/vm/assembler_arm_test.cc File runtime/vm/assembler_arm_test.cc (right): https://codereview.chromium.org/606893002/diff/1/runtime/vm/assembler_arm_test.cc#newcode110 ...
6 years, 2 months ago (2014-09-25 22:04:01 UTC) #3
Cutch
lgtm
6 years, 2 months ago (2014-09-25 22:07:17 UTC) #4
zra
vmovsr is available on platforms with vfp, but it can mess up the SIMD pipeline. ...
6 years, 2 months ago (2014-09-25 22:08:26 UTC) #5
zra
6 years, 2 months ago (2014-09-25 22:09:33 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r40696 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698