Add browser path options to testing scripts.

Add browser path options to testing scripts.

BUG=
R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29981

[Bill Hesse, 2013-11-05 18:21:39]

https://codereview.chromium.org/60503002/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/60503002/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:505: 'time', 'dart', 'drt', 'dartium',
'firefox', 'build_directory',
Add the two other ones here.

[kustermann, 2013-11-06 09:33:01]

In general it lgtm, but if you agree with my comments, you could change it.

https://codereview.chromium.org/60503002/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/60503002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:44: String _getBinary();
In effect, this method is used for getting the default path to the browser.

Why can't we just do that in test_options.dart ?
We have default values for other options as well.
This would eliminate all _Binary() methods.

https://codereview.chromium.org/60503002/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:1051: browser.setBinary(browserName,
globalConfiguration);
There's one thing I don't like about this:
If we create a new browser instance we always have to remember calling
'browser.SetBinary()' afterwards.

If we moved the default path of browsers to test_options.dart we can get rid of
this globalConfiguration parameter and just pass the executable to the
constructor:

"var browser = new Browser.byName(browserName,
globalConfiguration[browserName])"

[Bill Hesse, 2013-11-06 14:05:16]

Refactored the change.  PTAL.

[kustermann, 2013-11-06 14:28:00]

LGTM with comment.

https://codereview.chromium.org/60503002/diff/100001/tools/testing/dart/utils...
File tools/testing/dart/utils.dart (right):

https://codereview.chromium.org/60503002/diff/100001/tools/testing/dart/utils...
tools/testing/dart/utils.dart:135: switch (browserName) {
You could do something like this, to make it a bit more readable:
var browserLocations = {
  'firefox' : {
    'windows' : '...',
    'linux' : '...',
    'macos' : '...',
  }
  'ie9' : {
    'windows' : '...',
  }
  ...
}

if (browserLocations.containsKey(browserName)) {
  throw "unsupported browser";
}

if (!browserLocations[browserName].containsKey(Platform.operatingSystem)) {
  throw "$browserName not supported on ${Platform.operatingSystem}";
}
return browserLocations[browserName][Platform.operatingSystem];

[Bill Hesse, 2013-11-06 16:24:42]

Committed patchset #3 manually as r29981 (presubmit successful).