Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 600933004: Precompute untransformed packages when determining trnasformer dependencies. (Closed)

Created:
6 years, 2 months ago by nweiz
Modified:
6 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Precompute untransformed packages when determining trnasformer dependencies. This takes "pub run polymer:new_element --help" from 0.96s to 0.75s. R=rnystrom@google.com BUG=20859 Committed: https://code.google.com/p/dart/source/detail?r=40663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart View 3 chunks +17 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/dependency_computer.dart View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 2 months ago (2014-09-25 00:36:40 UTC) #1
Bob Nystrom
LGTM!
6 years, 2 months ago (2014-09-25 00:44:27 UTC) #2
nweiz
6 years, 2 months ago (2014-09-25 00:52:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698