Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/dependency_computer.dart

Issue 600933004: Precompute untransformed packages when determining trnasformer dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub_generated/lib/src/barback/dependency_computer.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/dependency_computer.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/dependency_computer.dart
index 8564e5bec565a7a203ea34af9cd5e43849934fd0..0dc6d67982a9ed06d9500ee56c715a31d486413b 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/barback/dependency_computer.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/dependency_computer.dart
@@ -14,7 +14,14 @@ class DependencyComputer {
final _loadingPackageComputers = new Set<String>();
final _packageComputers = new Map<String, _PackageDependencyComputer>();
final _transformersNeededByPackages = new Map<String, Set<TransformerId>>();
+ final _untransformedPackages = new Set<String>();
DependencyComputer(this._graph) {
+ for (var package in ordered(_graph.packages.keys)) {
+ if (_graph.transitiveDependencies(
+ package).every((dependency) => dependency.pubspec.transformers.isEmpty)) {
+ _untransformedPackages.add(package);
+ }
+ }
ordered(_graph.packages.keys).forEach(_loadPackageComputer);
}
Map<TransformerId, Set<TransformerId>>
@@ -54,6 +61,7 @@ class DependencyComputer {
Set<TransformerId> _transformersNeededByPackageUri(Uri packageUri) {
var components = p.split(p.fromUri(packageUri.path));
var packageName = components.first;
+ if (_untransformedPackages.contains(packageName)) return new Set();
var package = _graph.packages[packageName];
if (package == null) {
fail(
@@ -64,6 +72,7 @@ class DependencyComputer {
return _packageComputers[packageName].transformersNeededByLibrary(library);
}
Set<TransformerId> _transformersNeededByPackage(String rootPackage) {
+ if (_untransformedPackages.contains(rootPackage)) return new Set();
if (_transformersNeededByPackages.containsKey(rootPackage)) {
return _transformersNeededByPackages[rootPackage];
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698