Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 599303002: Don't use .gitignore when determining what to build/serve/run. (Closed)

Created:
6 years, 2 months ago by Bob Nystrom
Modified:
6 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use .gitignore when determining what to build/serve/run. (Still use it for publishing.) BUG=https://code.google.com/p/dart/issues/detail?id=9841 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=40661

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use .gitignore in dartdoc validator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -196 lines) Patch
M sdk/lib/_internal/pub/lib/src/command/lish.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/package.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/package_list_files_test.dart View 3 chunks +14 lines, -4 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/does_not_serve_gitignored_assets_in_a_path_dependency_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/does_not_serve_gitignored_assets_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/serves_hidden_assets_that_arent_gitignored_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/command/lish.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/package.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/validator/compiled_dartdoc.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/package_list_files_test.dart View 4 chunks +15 lines, -4 lines 0 comments Download
D sdk/lib/_internal/pub_generated/test/serve/does_not_serve_gitignored_assets_in_a_path_dependency_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D sdk/lib/_internal/pub_generated/test/serve/does_not_serve_gitignored_assets_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D sdk/lib/_internal/pub_generated/test/serve/serves_hidden_assets_that_arent_gitignored_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bob Nystrom
6 years, 2 months ago (2014-09-25 00:20:11 UTC) #2
nweiz
https://codereview.chromium.org/599303002/diff/1/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart File sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart (left): https://codereview.chromium.org/599303002/diff/1/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart#oldcode103 sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart:103: }); This should still work as it used to, ...
6 years, 2 months ago (2014-09-25 00:22:31 UTC) #3
Bob Nystrom
https://codereview.chromium.org/599303002/diff/1/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart File sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart (left): https://codereview.chromium.org/599303002/diff/1/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart#oldcode103 sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart:103: }); On 2014/09/25 00:22:31, nweiz wrote: > This should ...
6 years, 2 months ago (2014-09-25 00:36:55 UTC) #4
nweiz
lgtm
6 years, 2 months ago (2014-09-25 00:37:52 UTC) #5
Bob Nystrom
6 years, 2 months ago (2014-09-25 00:39:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698