Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: sdk/lib/_internal/pub_generated/test/package_list_files_test.dart

Issue 599303002: Don't use .gitignore when determining what to build/serve/run. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use .gitignore in dartdoc validator. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/test/package_list_files_test.dart
diff --git a/sdk/lib/_internal/pub_generated/test/package_list_files_test.dart b/sdk/lib/_internal/pub_generated/test/package_list_files_test.dart
index 466ee82e9a642e8393ff480bdb1f8ab46166625e..7a2c8616f1960438884a7a63f0931eabd3a89657 100644
--- a/sdk/lib/_internal/pub_generated/test/package_list_files_test.dart
+++ b/sdk/lib/_internal/pub_generated/test/package_list_files_test.dart
@@ -6,8 +6,8 @@ import '../lib/src/io.dart';
import '../lib/src/system_cache.dart';
import 'descriptor.dart' as d;
import 'test_pub.dart';
-var root;
-var entrypoint;
+String root;
+Entrypoint entrypoint;
main() {
initConfig();
group('not in a git repo', () {
@@ -69,7 +69,7 @@ main() {
path.join(root, 'subdir', 'subfile2.txt')]));
});
});
- integration("ignores files that are gitignored", () {
+ integration("ignores files that are gitignored if desired", () {
d.dir(
appPath,
[
@@ -83,7 +83,7 @@ main() {
d.file('subfile2.text', 'subcontents')])]).create();
schedule(() {
expect(
- entrypoint.root.listFiles(),
+ entrypoint.root.listFiles(useGitIgnore: true),
unorderedEquals(
[
path.join(root, 'pubspec.yaml'),
@@ -91,6 +91,17 @@ main() {
path.join(root, 'file2.text'),
path.join(root, 'subdir', 'subfile2.text')]));
});
+ schedule(() {
+ expect(
+ entrypoint.root.listFiles(),
+ unorderedEquals(
+ [
+ path.join(root, 'pubspec.yaml'),
+ path.join(root, 'file1.txt'),
+ path.join(root, 'file2.text'),
+ path.join(root, 'subdir', 'subfile1.txt'),
+ path.join(root, 'subdir', 'subfile2.text')]));
+ });
});
commonTests();
});

Powered by Google App Engine
This is Rietveld 408576698