Issue 59683002: Clean up Parser::ParseTryStatement in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59683002: Clean up Parser::ParseTryStatement in the VM. (Closed)

Created:
7 years, 1 month ago by Kevin Millikin (Google)

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up Parser::ParseTryStatement in the VM. Streamline the implementation, factor out repeated code, rename some cryptic identifiers, and fix a misspelling. Also, disentangle an implicit include dependency: class_finalizer.cc was getting code_generator.h implicitly from something included (unnecessarily as it turns out) by parser.h. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29900

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -161 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.h	View	3 chunks	+29 lines, -14 lines	1 comment	Download
M	runtime/vm/parser.cc	View	14 chunks	+125 lines, -146 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Committed patchset #1 manually as r29900 (presubmit successful).

7 years, 1 month ago (2013-11-05 12:49:23 UTC) #3

Ivan Posva

7 years, 1 month ago (2013-11-06 00:47:16 UTC) #4

Message was sent while issue was closed.

DBC

-Ivan

https://codereview.chromium.org/59683002/diff/1/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/59683002/diff/1/runtime/vm/parser.h#newcode11
runtime/vm/parser.h:11: #include "platform/assert.h"
Please explain why you needed platform/assert.h in this file? I do not see it
being used in any of the new code in here.

Expand Messages | Collapse Messages