Clean up Parser::ParseTryStatement in the VM.

runtime/vm/parser.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_PARSER_H_
 #define VM_PARSER_H_
 
 #include "include/dart_api.h"
 
 #include "lib/invocation_mirror.h"
-#include "vm/ast.h"
+#include "platform/assert.h"

[Ivan Posva, 2013/11/06 00:47:17]

Please explain why you needed platform/assert.h in this file? I do not see it
being used in any of the new code in here.

+#include "platform/globals.h"
+#include "vm/allocation.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler_stats.h"
-#include "vm/scanner.h"
+#include "vm/object.h"
+#include "vm/raw_object.h"
+#include "vm/token.h"
 
 namespace dart {
 
 // Forward declarations.
+class ArgumentListNode;
 class ArgumentsDescriptor;
-class Function;
+class AstNode;
+class CaseNode;
+class ClassDesc;
+class ConstructorCallNode;
+template <typename T> class GrowableArray;
+class InlinedFinallyNode;
 class Isolate;
-class LiteralToken;
-class Script;
-class TokenStream;
+class LetNode;
+class LiteralNode;
+class LocalScope;
+class LocalVariable;
+class PrimaryNode;
+class SequenceNode;
+class SourceLabel;
+class StaticCallNode;
 
-struct TopLevel;
-class ClassDesc;
+struct CatchParameter;
 struct MemberDesc;
 struct ParamList;
 struct QualIdent;
-struct CatchParamDesc;
-struct FieldInitExpression;
+struct TopLevel;
 
 // The class ParsedFunction holds the result of parsing a function.
 class ParsedFunction : public ZoneAllocated {
  public:
   explicit ParsedFunction(const Function& function)
       : function_(function),
         node_sequence_(NULL),
         instantiator_(NULL),
         default_parameter_values_(Array::ZoneHandle()),
         saved_current_context_var_(NULL),
@@ skipping 455 matching lines @@
   AstNode* ParseDoWhileStatement(String* label_name);
   AstNode* ParseForStatement(String* label_name);
   AstNode* ParseForInStatement(intptr_t forin_pos, SourceLabel* label);
   RawClass* CheckCaseExpressions(const GrowableArray<LiteralNode*>& values);
   CaseNode* ParseCaseClause(LocalVariable* switch_expr_value,
                             GrowableArray<LiteralNode*>* case_expr_values,
                             SourceLabel* case_label);
   AstNode* ParseSwitchStatement(String* label_name);
 
   // try/catch/finally parsing.
-  void AddCatchParamsToScope(const CatchParamDesc& exception_param,
-                             const CatchParamDesc& stack_trace_param,
-                             LocalScope* scope);
+  void AddCatchParametersToScope(CatchParameter* exception_param,
+                                 CatchParameter* stack_trace_param,
+                                 LocalScope* scope);
   // Parse finally block and create an AST for it.
   SequenceNode* ParseFinallyBlock();
   // Adds try block to the list of try blocks seen so far.
   void PushTryBlock(Block* try_block);
   // Pops the inner most try block from the list.
   TryBlocks* PopTryBlock();
   // Add specified node to try block list so that it can be patched with
   // inlined finally code if needed.
   void AddNodeForFinallyInlining(AstNode* node);
   // Add the inlined finally block to the specified node.
@@ skipping 102 matching lines @@
                                 Token::Kind binary_op,
                                 AstNode* lhs,
                                 AstNode* rhs);
   AstNode* ExpandAssignableOp(intptr_t op_pos,
                               Token::Kind assignment_op,
                               AstNode* lhs,
                               AstNode* rhs);
   LetNode* PrepareCompoundAssignmentNodes(AstNode** expr);
   LocalVariable* CreateTempConstVariable(intptr_t token_pos, const char* s);
 
+  LocalVariable* EnsureLocalVariable(const String& name);
+
   static SequenceNode* NodeAsSequenceNode(intptr_t sequence_pos,
                                           AstNode* node,
                                           LocalScope* scope);
 
   SequenceNode* MakeImplicitConstructor(const Function& func);
   AstNode* MakeStaticCall(const String& cls_name,
                           const String& func_name,
                           ArgumentListNode* arguments);
   String& Interpolate(const GrowableArray<AstNode*>& values);
   AstNode* MakeAssertCall(intptr_t begin, intptr_t end);
@@ skipping 77 matching lines @@
   intptr_t last_used_try_index_;
 
   bool unregister_pending_function_;
 
   DISALLOW_COPY_AND_ASSIGN(Parser);
 };
 
 }  // namespace dart
 
 #endif  // VM_PARSER_H_