Propagate future returned by _updateElementReferences().

Propagate future returned by _updateElementReferences().

Otherwise the Future.forEach() may complete too soon, causing the
refactoring to be returned to the client before all of the necessary
changes have been accumulated.

BUG=dartbug.com/21071
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40637

[Paul Berry, 2014-09-24 17:36:20]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-09-24 17:40:01]

LGTM

https://codereview.chromium.org/596423002/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/596423002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:62:
return _updateElementReferences(element);
Thanks!

convert_getter_to_method.dart exhibits the same problem.
It might be worth to fix it in the same CL too.

[Paul Berry, 2014-09-24 17:49:07]

https://codereview.chromium.org/596423002/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/596423002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:62:
return _updateElementReferences(element);
On 2014/09/24 17:40:00, scheglov wrote:
> Thanks!
> 
> convert_getter_to_method.dart exhibits the same problem.
> It might be worth to fix it in the same CL too.

Done.

[Paul Berry, 2014-09-24 17:52:49]

Committed patchset #2 (id:20001) manually as 40637 (presubmit successful).