pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart - Issue 596423002: Propagate future returned by _updateElementReferences().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

Issue 596423002: Propagate future returned by _updateElementReferences(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Also fix convert_getter_to_method.dart Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

index 7a63d3189e109fed64f35a011ee110cf3b08ee4f..c8fe46018737ed72859bd7515c0e692d5231639e 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

@@ -59,7 +59,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl implements

return getHierarchyMembers(searchEngine, method).then((elements) {

return Future.forEach(elements, (Element element) {

_updateElementDeclaration(element);

- _updateElementReferences(element);

+ return _updateElementReferences(element);

});

}).then((_) => change);

}

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart ('k') | no next file » | no next file with comments »