Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 596313002: dart2js: move reusable parts of interceptor emitter into a separate file. (Closed)

Created:
6 years, 3 months ago by floitsch
Modified:
6 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2js: move reusable parts of interceptor emitter into a separate file. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41132

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -463 lines) Patch
A + sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_stub_generator.dart View 1 3 chunks +35 lines, -163 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/interceptor_emitter.dart View 1 2 chunks +14 lines, -300 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
Depends on https://codereview.chromium.org/602663002
6 years, 3 months ago (2014-09-24 14:08:36 UTC) #2
floitsch
ping.
6 years, 2 months ago (2014-10-14 18:16:39 UTC) #3
Johnni Winther
lgtm
6 years, 2 months ago (2014-10-15 07:21:55 UTC) #4
floitsch
6 years, 2 months ago (2014-10-15 14:30:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41132 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698