Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 602663002: Split interceptor emitter. (Closed)

Created:
6 years, 2 months ago by floitsch
Modified:
6 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4 (1 generated)
floitsch
https://codereview.chromium.org/602663002/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/602663002/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart#newcode63 sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:63: Set<ClassElement> interceptorsReferencedFromConstants() { Straight copy from `interceptor_emitter.dart`.
6 years, 2 months ago (2014-09-24 14:02:06 UTC) #2
Johnni Winther
lgtm
6 years, 2 months ago (2014-09-25 07:08:42 UTC) #3
floitsch
6 years, 2 months ago (2014-09-25 12:30:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698