Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 595103002: Ensure dart and pub are on PATH when spawning binstub processes in test. (Closed)

Created:
6 years, 2 months ago by Bob Nystrom
Modified:
6 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure dart and pub are on PATH when spawning binstub processes in test. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=40617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_executable_test.dart View 3 chunks +19 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
6 years, 2 months ago (2014-09-23 23:42:06 UTC) #2
nweiz
lgtm
6 years, 2 months ago (2014-09-23 23:44:49 UTC) #3
Bob Nystrom
6 years, 2 months ago (2014-09-23 23:45:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698