Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart

Issue 595103002: Ensure dart and pub are on PATH when spawning binstub processes in test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_executable_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart
diff --git a/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart b/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart
index 1c7b9f87d1498b433993492ad7051ff81ce6512f..f2b0f0d14014f40ef16b808b2e706722e2599254 100644
--- a/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart
+++ b/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart
@@ -1,5 +1,7 @@
+import 'dart:io';
import 'package:path/path.dart' as p;
import 'package:scheduled_test/scheduled_process.dart';
+import 'package:scheduled_test/scheduled_test.dart';
import '../../descriptor.dart' as d;
import '../../test_pub.dart';
main() {
@@ -17,7 +19,8 @@ main() {
schedulePub(args: ["global", "activate", "foo"]);
var process = new ScheduledProcess.start(
p.join(sandboxDir, cachePath, "bin/foo-script"),
- ["arg1", "arg2"]);
+ ["arg1", "arg2"],
+ environment: getEnvironment());
process.stdout.expect("ok [arg1, arg2]");
process.shouldExit();
});
@@ -35,8 +38,16 @@ main() {
var process = new ScheduledProcess.start(
p.join(sandboxDir, cachePath, "bin/foo-script"),
["arg1", "arg2"],
- environment: getPubTestEnvironment());
+ environment: getEnvironment());
process.stdout.expect("ok [arg1, arg2]");
process.shouldExit();
});
}
+getEnvironment() {
+ var binDir = p.dirname(Platform.executable);
+ var separator = Platform.operatingSystem == "windows" ? ";" : ":";
+ var path = "${Platform.environment["PATH"]}$separator$binDir";
+ var environment = getPubTestEnvironment();
+ environment["PATH"] = path;
+ return environment;
+}
« no previous file with comments | « sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_executable_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698