Issue 59463004: Fix the generic type of Map.values for map literals.

Issue 59463004: Fix the generic type of Map.values for map literals. (Closed)

Created:
7 years, 1 month ago by floitsch

Modified:
7 years, 1 month ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix the generic type of Map.values for map literals. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=29995

Patch Set 3 : Update status file. #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -32 lines)			Patch
M	sdk/lib/_internal/lib/collection_patch.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/constant_map.dart	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 2	1 chunk	+2 lines, -2 lines	2 comments	Download
A +	tests/corelib/map_values3_test.dart	View		1 chunk	+21 lines, -21 lines	0 comments	Download
A	tests/corelib/map_values4_test.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/59463004/diff/70001/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/59463004/diff/70001/tests/corelib/corelib.status#newcode111 tests/corelib/corelib.status:111: map_values4_test: RuntimeError # Issue: 14837 I have a ...

7 years, 1 month ago (2013-11-06 14:14:52 UTC) #2

floitsch

https://codereview.chromium.org/59463004/diff/70001/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/59463004/diff/70001/tests/corelib/corelib.status#newcode111 tests/corelib/corelib.status:111: map_values4_test: RuntimeError # Issue: 14837 On 2013/11/06 14:14:52, karlklose ...

7 years, 1 month ago (2013-11-06 20:57:25 UTC) #3

floitsch

7 years, 1 month ago (2013-11-06 20:58:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r29995 (presubmit successful).

Expand Messages | Collapse Messages