Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: tests/corelib/map_values3_test.dart

Issue 59463004: Fix the generic type of Map.values for map literals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib/map_values3_test.dart
diff --git a/tests/corelib/map_values2_test.dart b/tests/corelib/map_values3_test.dart
similarity index 56%
copy from tests/corelib/map_values2_test.dart
copy to tests/corelib/map_values3_test.dart
index 9718949e48815973cf3503f425a0a8c9540a0a93..617f1fce6e0dfed6ee2671f203c70f01e5095e31 100644
--- a/tests/corelib/map_values2_test.dart
+++ b/tests/corelib/map_values3_test.dart
@@ -5,48 +5,48 @@
import "package:expect/expect.dart";
main() {
- var map1 = <String, int>{ "foo": 42, "bar": 499 };
- var map2 = <String, int>{};
- var map3 = const <String, int>{ "foo": 42, "bar": 499 };
- var map4 = const <String, int>{};
- var map5 = new Map<String, int>();
- map5["foo"] = 43;
- map5["bar"] = 500;
- var map6 = new Map<String, int>();
-
- Expect.isTrue(map1.values is Iterable<int>);
+ var map1 = <int, String>{ 1: "42", 2: "499" };
+ var map2 = <int, String>{};
+ var map3 = const <int, String>{ 3: "42", 4: "499" };
+ var map4 = const <int, String>{};
+ var map5 = new Map<int, String>();
+ map5[5] = "43";
+ map5[6] = "500";
+ var map6 = new Map<int, String>();
+
+ Expect.isTrue(map1.values is Iterable<String>);
Expect.isFalse(map1.values is Iterable<bool>);
Expect.isFalse(map1.values is List);
Expect.equals(2, map1.values.length);
- Expect.equals(42, map1.values.first);
- Expect.equals(499, map1.values.last);
+ Expect.equals("42", map1.values.first);
+ Expect.equals("499", map1.values.last);
- Expect.isTrue(map2.values is Iterable<int>);
+ Expect.isTrue(map2.values is Iterable<String>);
Expect.isFalse(map2.values is Iterable<bool>);
Expect.isFalse(map2.values is List);
Expect.equals(0, map2.values.length);
- Expect.isTrue(map3.values is Iterable<int>);
+ Expect.isTrue(map3.values is Iterable<String>);
Expect.isFalse(map3.values is Iterable<bool>);
Expect.isFalse(map3.values is List);
Expect.equals(2, map3.values.length);
- Expect.equals(42, map3.values.first);
- Expect.equals(499, map3.values.last);
+ Expect.equals("42", map3.values.first);
+ Expect.equals("499", map3.values.last);
- Expect.isTrue(map4.values is Iterable<int>);
+ Expect.isTrue(map4.values is Iterable<String>);
Expect.isFalse(map4.values is Iterable<bool>);
Expect.isFalse(map4.values is List);
Expect.equals(0, map4.values.length);
- Expect.isTrue(map5.values is Iterable<int>);
+ Expect.isTrue(map5.values is Iterable<String>);
Expect.isFalse(map5.values is Iterable<bool>);
Expect.isFalse(map5.values is List);
Expect.equals(2, map5.values.length);
// new Map gives a LinkedHashMap, so we know the order.
- Expect.isTrue(map5.values.first == 43);
- Expect.isTrue(map5.values.last == 500);
+ Expect.isTrue(map5.values.first == "43");
+ Expect.isTrue(map5.values.last == "500");
- Expect.isTrue(map6.values is Iterable<int>);
+ Expect.isTrue(map6.values is Iterable<String>);
Expect.isFalse(map6.values is Iterable<bool>);
Expect.isFalse(map6.values is List);
Expect.equals(0, map6.values.length);

Powered by Google App Engine
This is Rietveld 408576698