Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 590513003: Add _Bigint._mulAdd to the invisible list. Strengthen the mirror invocation fuzzer. (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add _Bigint._mulAdd to the invisible list. Strengthen the mirror invocation fuzzer. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40576

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 2 6 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
6 years, 3 months ago (2014-09-19 18:25:01 UTC) #2
regis
LGTM https://codereview.chromium.org/590513003/diff/20001/tests/lib/mirrors/invocation_fuzz_test.dart File tests/lib/mirrors/invocation_fuzz_test.dart (right): https://codereview.chromium.org/590513003/diff/20001/tests/lib/mirrors/invocation_fuzz_test.dart#newcode6 tests/lib/mirrors/invocation_fuzz_test.dart:6: // invoke them will all nulls. This may ...
6 years, 3 months ago (2014-09-22 16:20:43 UTC) #3
rmacnak
Also marked dart2js as failing when minified https://codereview.chromium.org/590513003/diff/20001/tests/lib/mirrors/invocation_fuzz_test.dart File tests/lib/mirrors/invocation_fuzz_test.dart (right): https://codereview.chromium.org/590513003/diff/20001/tests/lib/mirrors/invocation_fuzz_test.dart#newcode6 tests/lib/mirrors/invocation_fuzz_test.dart:6: // invoke ...
6 years, 3 months ago (2014-09-22 22:42:12 UTC) #4
rmacnak
6 years, 3 months ago (2014-09-22 22:46:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698