Add _Bigint._mulAdd to the invisible list. Strengthen the mirror invocation fuzzer.

tests/lib/mirrors/invocation_fuzz_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This test reflectively enumerates all the methods in the system and tries to
 // invoke them will all nulls. This may result in Dart exceptions or hangs, but

[regis, 2014/09/22 16:20:43]

It's not just all nulls anymore.

[rmacnak, 2014/09/22 22:42:12]

Updated

 // should never result in crashes or JavaScript exceptions.
 
 library test.invoke_natives;
 
 import 'dart:mirrors';
 import 'dart:async';
-import 'package:expect/expect.dart';
 
 // Methods to be skipped, by qualified name.
 var blacklist = [
   // Don't recurse on this test.
   'test.invoke_natives',
 
   // Don't exit the test pre-maturely.
   'dart.io.exit',
 
   // Don't run blocking io calls.
   new RegExp(r".*Sync$"),
 
   // These prevent the test from exiting.
   'dart.async._scheduleAsyncCallback',
   'dart.async._setTimerFactoryClosure',
-
   'dart.isolate._startMainIsolate',
   'dart.isolate._startIsolate',
   'dart.io.sleep',
   'dart.io.HttpServer.HttpServer.listenOn',
+  new RegExp(r'dart.io.*'),  /// smi: ok
+
+  // Runtime exceptions we can't catch.
+  'dart.isolate._isolateScheduleImmediate',
+  'dart.io._Timer._createTimer',  /// smi: ok
 
   // These either cause the VM to segfault or throw uncatchable API errors.
   // TODO(15274): Fix them and remove from blacklist.
   'dart.io._IOService.dispatch',
   new RegExp(r'.*_RandomAccessFile.*'),
   'dart.io._StdIOUtils._socketType',
   'dart.io._StdIOUtils._getStdioOutputStream',
   'dart.io._Filter.newZLibInflateFilter',
   'dart.io._Filter.newZLibDeflateFilter',
   'dart.io._FileSystemWatcher._listenOnSocket',
   'dart.io.SystemEncoding.decode',
   'dart.io.SystemEncoding.encode',
-  'dart.core._Bigint._mulAdd',  // TODO(regis): Is this an intrinsic issue?
+  'dart.core.StringBuffer.toString',  /// emptyarray: ok
 ];
 
 bool isBlacklisted(Symbol qualifiedSymbol) {
   var qualifiedString = MirrorSystem.getName(qualifiedSymbol);
   for (var pattern in blacklist) {
     if (qualifiedString.contains(pattern)) return true;
   }
   return false;
 }
 
 class Task {
   var name;
   var action;
 }
 var queue = new List();
 
 checkMethod(MethodMirror m, ObjectMirror target, [origin]) {
   if (isBlacklisted(m.qualifiedName)) return;
 
   var task = new Task();
   task.name = '${MirrorSystem.getName(m.qualifiedName)} from $origin';
 
   if (m.isRegularMethod) {
     task.action =
-        () => target.invoke(m.simpleName, new List(m.parameters.length));
+      () => target.invoke(m.simpleName,
+                          new List.filled(m.parameters.length, fuzzArgument));
   } else if (m.isGetter) {
     task.action =
         () => target.getField(m.simpleName);
   } else if (m.isSetter) {
     task.action =
         () => target.setField(m.simpleName, null);
   } else if (m.isConstructor) {
     return;
   } else {
     throw "Unexpected method kind";
@@ skipping 18 matching lines @@
       .forEach((m) => checkMethod(m, classMirror));
 
   classMirror.declarations.values
       .where((d) => d is MethodMirror && d.isConstructor)
       .forEach((m) {
     if (isBlacklisted(m.qualifiedName)) return;
     var task = new Task();
     task.name = MirrorSystem.getName(m.qualifiedName);
 
     task.action = () {
-      var instance = classMirror.newInstance(m.constructorName,
-                                             new List(m.parameters.length));
+      var instance = classMirror.newInstance(
+          m.constructorName,
+          new List.filled(m.parameters.length, fuzzArgument));
       checkInstance(instance, task.name);
     };
     queue.add(task);
   });
 }
 
 checkLibrary(libraryMirror) {
   print(libraryMirror.simpleName);
   if (isBlacklisted(libraryMirror.qualifiedName)) return;
 
   libraryMirror.declarations.values
       .where((d) => d is ClassMirror)
       .forEach(checkClass);
 
   libraryMirror.declarations.values
       .where((d) => d is MethodMirror)
       .forEach((m) => checkMethod(m, libraryMirror));
 }
 
 var testZone;
 
 doOneTask() {
   if (queue.length == 0) {
     print('Done');
     return;
   }
 
   var task = queue.removeLast();
-  print(task.name);
+  //print(task.name);

[regis, 2014/09/22 16:20:43]

Remove commented out line?

[rmacnak, 2014/09/22 22:42:12]

Uncommenting so this is on for the bot.

   try {
     task.action();
   } catch(e) {}
 
   // Register the next task in a timer callback so as to yield to async code
   // scheduled in the current task. This isn't necessary for the test itself,
   // but is helpful when trying to figure out which function is responsible for
   // a crash.
   testZone.createTimer(Duration.ZERO, doOneTask);
 }
 
+var fuzzArgument;
+
 main([args]) {
+  fuzzArgument = null;
+  fuzzArgument = 1;  /// smi: ok
+  fuzzArgument = false;  /// false: ok
+  fuzzArgument = 'string';  /// string: ok
+  fuzzArgument = new List(0);  /// emptyarray: ok

[regis, 2014/09/22 16:20:43]

Do I understand correctly that we can now name multi tests? Neat.

[rmacnak, 2014/09/22 22:42:12]

Yep

+
   currentMirrorSystem().libraries.values.forEach(checkLibrary);
 
   var valueObjects =
     [true, false, null,
      0, 0xEFFFFFF, 0xFFFFFFFF, 0xFFFFFFFFFFFFFFFF,
-     "foo", 'blåbærgrød', 'Îñţérñåţîöñåļîžåţîờñ'];
+     "foo", 'blåbærgrød', 'Îñţérñåţîöñåļîžåţîờñ', "𝄞", #symbol];
   valueObjects.forEach((v) => checkInstance(reflect(v), 'value object'));
 
   uncaughtErrorHandler(self, parent, zone, error, stack) {};
   var zoneSpec =
      new ZoneSpecification(handleUncaughtError: uncaughtErrorHandler);
   testZone = Zone.current.fork(specification: zoneSpec);
   testZone.createTimer(Duration.ZERO, doOneTask);
 }