Pass a package root to spawned isolates in pub.

Pass a package root to spawned isolates in pub.

This allows pub to get rid of the RewriteImportTransformer. This reduces the
runtime of "pub run polymer:new_element --help" by about 270ms.

R=rnystrom@google.com
BUG=20859
Committed: https://code.google.com/p/dart/source/detail?r=40614

[Bob Nystrom, 2014-09-23 21:56:12]

LGTM!

> This reduces the runtime of "pub run polymer:new_element --help" by about
270ms.

From what?

- bob

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/rewrite_import_transformer.dart
(left):

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/rewrite_import_transformer.dart:3: //
BSD-style license that can be found in the LICENSE file.

     ,;``',
    ;      |
    ;;. ;;,'
     `"-'7'.   IT'S TIME TO CELEBRATE!!   _  /
         |' >.                         .'` |\  -
         | /  >.                   _\ /   /  |  -
         '/  / ,`.  __..----.       .'  .'  /  _
         ;  / /_.-'          \     /_.-`_.-'  \
          ;' .'  '`           |  - `-.-'
          |_/                .'   /   \_\_
          _|  |_    .____.-'`         / __)`\
         ( `  /\`'-...__.'  \        | '\(_.'|
          `-\   \ `-'-'-'|   `.      -.  \(_./
             \   \.-.-.  \     \___ /  >-'\_\
              \   \  \ \  `/\  |_  '` /
           _./\    \  ' | /    /_\ .-`
         .' _.\'.   '.__.'    /`\`'
  .-.---'\_/   `.`'-..____   ;   \
 / / .--. |,     `'-._   /`'.|    |
 `| /-' / / \         `.'    \   _/
  '-'  '-' \ `-._            _,-' |
            \    `'''----''''    /
             >                _.'
            / /`'-.._____..--'\ \
           < \                / /
            \ `.           .'  |___ mx
          ___\_ `.        /__.-'   ``--..
   ..--''`     `-.\      (___/`'--.._____)
  (_____...--'`\___)

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/transformer_isolate.dart (right):

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/transformer_isolate.dart:72:
"r'package:\$pub/transformer_isolate.dart';");
Will this fit on one line now?

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/dart.dart (right):

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/dart.dart:186:
snapshotArgs..addAll(['--snapshot=$snapshot', dartPath]));
Using a cascade here seems weird. Why not just do this after the if
(packageRoot... line?

[nweiz, 2014-09-23 23:22:40]

Committed patchset #1 (id:1) manually as 40614 (presubmit successful).

[nweiz, 2014-09-23 23:23:58]

> From what?

About 2.09s to 1.82s.

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/transformer_isolate.dart (right):

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/transformer_isolate.dart:72:
"r'package:\$pub/transformer_isolate.dart';");
On 2014/09/23 21:56:11, Bob Nystrom wrote:
> Will this fit on one line now?

Done.

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/dart.dart (right):

https://codereview.chromium.org/590393005/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/dart.dart:186:
snapshotArgs..addAll(['--snapshot=$snapshot', dartPath]));
On 2014/09/23 21:56:11, Bob Nystrom wrote:
> Using a cascade here seems weird. Why not just do this after the if
> (packageRoot... line?

Done.