Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/transformer_isolate.dart

Issue 590393005: Pass a package root to spawned isolates in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/barback/transformer_isolate.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_isolate.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_isolate.dart
index f45a9a81345740706adb952af707142c0ac4c0f2..ddcf8ffed2364468342ed8d5bebaf2a01d797dee 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_isolate.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_isolate.dart
@@ -28,15 +28,14 @@ class TransformerIsolate {
var baseUrl = transformerServer.url;
var idsToUrls = mapMap(idsToAssetIds, value: (id, assetId) {
var path = assetId.path.replaceFirst('lib/', '');
- return baseUrl.resolve('packages/${id.package}/$path');
+ return Uri.parse('package:${id.package}/$path');
});
var code = new StringBuffer();
code.writeln("import 'dart:isolate';");
for (var url in idsToUrls.values) {
code.writeln("import '$url';");
}
- code.writeln(
- "import " "r'$baseUrl/packages/\$pub/transformer_isolate.dart';");
+ code.writeln("import " "r'package:\$pub/transformer_isolate.dart';");
code.writeln(
"void main(_, SendPort replyTo) => loadTransformers(replyTo);");
log.fine("Loading transformers from $ids");
@@ -44,6 +43,7 @@ class TransformerIsolate {
return dart.runInIsolate(
code.toString(),
port.sendPort,
+ packageRoot: baseUrl.resolve('packages'),
snapshot: snapshot).then((_) => port.first).then((sendPort) {
return new TransformerIsolate._(sendPort, environment.mode, idsToUrls);
}).catchError((error, stackTrace) {
@@ -62,7 +62,7 @@ class TransformerIsolate {
TransformerIsolate._(this._port, this._mode, this._idsToUrls);
Future<Set<Transformer>> create(TransformerConfig config) {
return call(_port, {
- 'library': _idsToUrls[config.id].path.toString(),
+ 'library': _idsToUrls[config.id].toString(),
'mode': _mode.name,
'configuration': JSON.encode(config.configuration)
}).then((transformers) {

Powered by Google App Engine
This is Rietveld 408576698