Issue 589043003: Backout constant support

Issue 589043003: Backout constant support (Closed)

Created:
6 years, 3 months ago by Brian Wilkerson

Modified:
6 years, 3 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Backout constant support R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=40561

Patch Set 1 #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -52 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java	View	1 chunk	+12 lines, -9 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/object/InstanceState.java	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/constant/ConstantEvaluatorTest.java	View	6 chunks	+17 lines, -13 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java	View	3 chunks	+20 lines, -16 lines	0 comments	Download
M	tests/language/compile_time_constant12_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/language/compile_time_constant_c_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm https://codereview.chromium.org/589043003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java (right): https://codereview.chromium.org/589043003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java#newcode584 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java:584: // TODO(brianwilkerson) Replace the line below with the ...

6 years, 3 months ago (2014-09-22 19:31:01 UTC) #3

Brian Wilkerson

https://codereview.chromium.org/589043003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java (right): https://codereview.chromium.org/589043003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java#newcode584 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java:584: // TODO(brianwilkerson) Replace the line below with the commented ...

6 years, 3 months ago (2014-09-22 19:48:19 UTC) #4

Brian Wilkerson

6 years, 3 months ago (2014-09-22 19:48:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40561 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages