Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java

Issue 589043003: Backout constant support (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java
index 1af074f2f4bd8961cd4373ea3ba2d400cf39df13..bb3b758b6dbd840f876aec896d72b26bde3e7f07 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/object/DartObjectImplTest.java
@@ -25,6 +25,26 @@ import java.util.Map;
public class DartObjectImplTest extends EngineTestCase {
TypeProvider typeProvider = new TestTypeProvider();
+ public void fail_add_knownString_knownString() throws EvaluationException {
+ fail("New constant semantics are not yet enabled");
+ assertAdd(stringValue("ab"), stringValue("a"), stringValue("b"));
+ }
+
+ public void fail_add_knownString_unknownString() throws EvaluationException {
+ fail("New constant semantics are not yet enabled");
+ assertAdd(stringValue(null), stringValue("a"), stringValue(null));
+ }
+
+ public void fail_add_unknownString_knownString() throws EvaluationException {
+ fail("New constant semantics are not yet enabled");
+ assertAdd(stringValue(null), stringValue(null), stringValue("b"));
+ }
+
+ public void fail_add_unknownString_unknownString() throws EvaluationException {
+ fail("New constant semantics are not yet enabled");
+ assertAdd(stringValue(null), stringValue(null), stringValue(null));
+ }
+
public void test_add_knownDouble_knownDouble() throws EvaluationException {
assertAdd(doubleValue(3.0), doubleValue(1.0), doubleValue(2.0));
}
@@ -61,14 +81,6 @@ public class DartObjectImplTest extends EngineTestCase {
assertAdd(null, stringValue("1"), intValue(2));
}
- public void test_add_knownString_knownString() throws EvaluationException {
- assertAdd(stringValue("ab"), stringValue("a"), stringValue("b"));
- }
-
- public void test_add_knownString_unknownString() throws EvaluationException {
- assertAdd(stringValue(null), stringValue("a"), stringValue(null));
- }
-
public void test_add_unknownDouble_knownDouble() throws EvaluationException {
assertAdd(doubleValue(null), doubleValue(null), doubleValue(2.0));
}
@@ -85,14 +97,6 @@ public class DartObjectImplTest extends EngineTestCase {
assertAdd(intValue(null), intValue(null), intValue(2));
}
- public void test_add_unknownString_knownString() throws EvaluationException {
- assertAdd(stringValue(null), stringValue(null), stringValue("b"));
- }
-
- public void test_add_unknownString_unknownString() throws EvaluationException {
- assertAdd(stringValue(null), stringValue(null), stringValue(null));
- }
-
public void test_bitAnd_knownInt_knownInt() throws EvaluationException {
assertBitAnd(intValue(2), intValue(6), intValue(3));
}

Powered by Google App Engine
This is Rietveld 408576698