Update to polymer js version 0.4.1

Update to polymer js version 0.4.1

BUG= http://dartbug.com/21035
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40631

[jakemac, 2014-09-22 23:14:23]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[jakemac, 2014-09-22 23:14:24]

Chose not to migrate a few things, specifically:

The instanceOfType method. It is just really not necessary in dart.
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-820ea58e62e...

ComputedProperty was changed to read only, but in dart it was already this way
unless you specify and explicit setter.
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-38d8dd53b2c...,
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-97a777211ce...

[Siggi Cherem (dart-lang), 2014-09-23 21:08:35]

On 2014/09/22 23:14:24, jakemac wrote:
> Chose not to migrate a few things, specifically:
> 
> The instanceOfType method. It is just really not necessary in dart.
>
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-820ea58e62e...
> 
> ComputedProperty was changed to read only, but in dart it was already this way
> unless you specify and explicit setter.
>
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-38d8dd53b2c...,
>
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-97a777211ce...

Let's include a "Dart note:" comment for these, so we don't forget why we don't
have them.

[Siggi Cherem (dart-lang), 2014-09-23 21:08:53]

very nice, minor things, ow lgtm

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:9: inject html That is bound to your current element
into a target element.
That => that

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/inject_boun...
File pkg/polymer/test/inject_bound_html_test.dart (right):

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/inject_boun...
pkg/polymer/test/inject_bound_html_test.dart:26:
xFoo.injectBoundHTML('<span>{{bar}}</span>', injectDiv);
this is probably going to fail in dart2js unless we declare bar being used
somewhere, you can work around it by adding a computed expression above like:

@ComputedExpression('baz')
var ignore => readValue(#baz);

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/unbind_test...
File pkg/polymer/test/unbind_test.dart (left):

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/unbind_test...
pkg/polymer/test/unbind_test.dart:22: bool forceReady = true;
oh, when adding new methods is a breaking change. Fun :)

[jakemac, 2014-09-23 22:03:06]

On 2014/09/23 21:08:35, Siggi Cherem (dart-lang) wrote:
> On 2014/09/22 23:14:24, jakemac wrote:
> > Chose not to migrate a few things, specifically:
> > 
> > The instanceOfType method. It is just really not necessary in dart.
> >
>
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-820ea58e62e...
> > 
> > ComputedProperty was changed to read only, but in dart it was already this
way
> > unless you specify and explicit setter.
> >
>
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-38d8dd53b2c...,
> >
>
https://github.com/Polymer/polymer-dev/compare/0.4.0...0.4.1#diff-97a777211ce...
> 
> Let's include a "Dart note:" comment for these, so we don't forget why we
don't
> have them.

Where should I put the note do you think?

[jakemac, 2014-09-23 22:15:02]

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:9: inject html That is bound to your current element
into a target element.
On 2014/09/23 21:08:53, Siggi Cherem (dart-lang) wrote:
> That => that

Done.

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/inject_boun...
File pkg/polymer/test/inject_bound_html_test.dart (right):

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/inject_boun...
pkg/polymer/test/inject_bound_html_test.dart:26:
xFoo.injectBoundHTML('<span>{{bar}}</span>', injectDiv);
On 2014/09/23 21:08:53, Siggi Cherem (dart-lang) wrote:
> this is probably going to fail in dart2js unless we declare bar being used
> somewhere, you can work around it by adding a computed expression above like:
> 
> @ComputedExpression('baz')
> var ignore => readValue(#baz);

Done.

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/unbind_test...
File pkg/polymer/test/unbind_test.dart (left):

https://codereview.chromium.org/588373003/diff/1/pkg/polymer/test/unbind_test...
pkg/polymer/test/unbind_test.dart:22: bool forceReady = true;
On 2014/09/23 21:08:52, Siggi Cherem (dart-lang) wrote:
> oh, when adding new methods is a breaking change. Fun :)

Done.

[Siggi Cherem (dart-lang), 2014-09-23 22:27:24]

lgtm

[jakemac, 2014-09-24 16:18:09]

Committed patchset #2 (id:10001) manually as 40631 (presubmit successful).