Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: pkg/polymer/lib/src/property_accessor.dart

Issue 588373003: Update to polymer js version 0.4.1 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: review updates Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/js/polymer/polymer.concat.js.map ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/property_accessor.dart
diff --git a/pkg/polymer/lib/src/property_accessor.dart b/pkg/polymer/lib/src/property_accessor.dart
index b639b47a3b9612f3fbf33599e6fc26b0eb2d34c5..9903d55d3ae42000f3650d30110e66b83d59d2e7 100644
--- a/pkg/polymer/lib/src/property_accessor.dart
+++ b/pkg/polymer/lib/src/property_accessor.dart
@@ -51,6 +51,9 @@ class _PropertyAccessor<T> {
}
set value(T newValue) {
+ // Dart Note: The js side makes computed properties read only, and bails
+ // out right here for them (ignoreWrites). For us they are automatically
+ // read only unless you define a setter for them, so we left that out.
if (bindable != null) {
bindable.value = newValue;
} else {
« no previous file with comments | « pkg/polymer/lib/src/js/polymer/polymer.concat.js.map ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698