Replace AnalysisServerListener with Stream.

Replace AnalysisServerListener with Stream.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=40557

[Brian Wilkerson, 2014-09-22 13:59:53]

I'm not familiar with Streams in Dart, so this doesn't look like an improvement
to me. Is this a general replacement for the listener pattern? I seems strange
to have to pass in a value (of null) when no value is desired.

[Paul Berry, 2014-09-22 15:52:22]

This looks much more Dart-ish to me--I like it.  With the issue below fixed,
lgtm.

https://codereview.chromium.org/587783003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/587783003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:240:
_onAnalysisCompleteController.add(null);
This will notify *all* listeners that analysis is complete.  I don't think
that's what we want.  I'd recommend dropping the onListen() method and making
the client responsible for checking isAnalysisComplete() at the time that it
subscribes.

[Brian Wilkerson, 2014-09-22 16:41:16]

I didn't notice earlier, but I don't think this change is useful because we need
to re-work the launch data notifications so that they no longer depend on
waiting for analysis to complete.

[scheglov, 2014-09-22 18:03:18]

PTAL

https://codereview.chromium.org/587783003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/587783003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:240:
_onAnalysisCompleteController.add(null);
On 2014/09/22 15:52:21, Paul Berry wrote:
> This will notify *all* listeners that analysis is complete.  I don't think
> that's what we want.  I'd recommend dropping the onListen() method and making
> the client responsible for checking isAnalysisComplete() at the time that it
> subscribes.

Done.

[Paul Berry, 2014-09-22 18:21:39]

lgtm

[Brian Wilkerson, 2014-09-22 18:24:50]

LGTM

[scheglov, 2014-09-22 18:35:37]

Committed patchset #2 (id:20001) manually as 40557 (presubmit successful).