Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 587783003: Replace AnalysisServerListener with Stream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merges and fixes for comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/edit/edit_domain.dart
diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart
index bf27d38ecea81006b96bebd2347968d9214e22c3..128deed914e4b47d18bde7ad4d1506058fce1119 100644
--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart
+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart
@@ -20,6 +20,7 @@ import 'package:analyzer/src/generated/element.dart';
import 'package:analyzer/src/generated/engine.dart' as engine;
import 'package:analyzer/src/generated/error.dart' as engine;
import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer/src/generated/engine.dart';
/**
@@ -180,8 +181,7 @@ class _RefactoringManager {
EditGetRefactoringResult result;
_RefactoringManager(this.server, this.searchEngine) {
- server.addAnalysisServerListener(
- new _ResetRefactoringManagerAnalysisServerListener(this));
+ server.onAnalysisStarted.listen(_reset);
_reset();
}
@@ -374,7 +374,7 @@ class _RefactoringManager {
});
}
- void _reset() {
+ void _reset([AnalysisContext context]) {
kind = null;
offset = null;
length = null;
@@ -442,24 +442,3 @@ class _RefactoringManager {
return new RefactoringStatus();
}
}
-
-
-/**
- * A [AnalysisServerListener] that resets [_RefactoringManager] when analysis
- * is started in the [AnalysisServer].
- */
-class _ResetRefactoringManagerAnalysisServerListener implements
- AnalysisServerListener {
- final _RefactoringManager refactoringManager;
-
- _ResetRefactoringManagerAnalysisServerListener(this.refactoringManager);
-
- @override
- void analysisComplete() {
- }
-
- @override
- void analysisStarted(engine.AnalysisContext context) {
- refactoringManager._reset();
- }
-}
« no previous file with comments | « pkg/analysis_server/lib/src/domain_execution.dart ('k') | pkg/analysis_server/test/domain_execution_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698