Issue 585073002: Issue 18296. Harden the name checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 585073002: Issue 18296. Harden the name checks. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -65 lines)			Patch
M	pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart	View	15 chunks	+15 lines, -15 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/extract_method_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart	View	27 chunks	+49 lines, -49 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

6 years, 3 months ago (2014-09-19 20:53:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40521 (presubmit successful).