pkg/analysis_server/test/services/refactoring/extract_method_test.dart - Issue 585073002: Issue 18296. Harden the name checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/refactoring/extract_method_test.dart

Issue 585073002: Issue 18296. Harden the name checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart ('k') | pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/refactoring/extract_method_test.dart

diff --git a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart

index b4adb6cb19b5f2278e792f112dcf9a42ef7216eb..8001fc0f8663b544520c404c13899e8dec4cd142 100644

--- a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart

+++ b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart

@@ -343,7 +343,7 @@ main() {

_createRefactoringForStartEndComments();

refactoring.name = 'bad-name';

// check conditions

- return _assertConditionsError("Method name must not contain '-'.");

+ return _assertConditionsFatal("Method name must not contain '-'.");

}

test_bad_notSameParent() {